#1882 use ClassValue instead of synchronized WeakHashMap in ClassFactory#1883
Merged
laurentschoelens merged 3 commits intoeclipse-ee4j:masterfrom Feb 3, 2026
Conversation
…o avoid locking issues under heavy multithreaded load)
winfriedgerlach
changed the title
Contributor
|
@winfriedgerlach : build is failing on jdk11, could you check why ? Does it fail too on your side ? |
winfriedgerlach
changed the title
Contributor
Author
|
@laurentschoelens fixed |
laurentschoelens
added
enhancement
laurentschoelens
requested changes
Jan 30, 2026
Contributor
laurentschoelens
left a comment
laurentschoelens
left a comment
There was a problem hiding this comment.
Good for me (as far as I know about ClassValue usage)
Please fix my few comments and I'll approve on my side
jaxb-ri/core/src/main/java/org/glassfish/jaxb/core/v2/ClassFactory.java
Outdated
Show resolved
Hide resolved
jaxb-ri/core/src/main/java/org/glassfish/jaxb/core/v2/ClassFactory.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(to avoid locking issues under heavy multithreaded load)
closes #1882